Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run analyzers that sonar cloud runs #814

Closed
wants to merge 1 commit into from
Closed

Run analyzers that sonar cloud runs #814

wants to merge 1 commit into from

Conversation

ivarne
Copy link
Member

@ivarne ivarne commented Oct 6, 2024

This enables analysers that Sonar Cloud runs so that they can be caught in local development instead of the slow cycle of getting an issue in sonar cloud.

This is part of #730, because I changed these to warning in .editorconfig because it made the sonar cloud issues easier to find. I think this could be reviewed separately.

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@ivarne
Run analyzers that sonar cloud runs
d5d5baf 
It is annoying to not get warnings in local dev, that I have to fix when creating a PR
@martinothamar
Copy link
Contributor

nice! are you adding SonarAnalyzer.CSharp as well or is this just about catching builtin warnings that sonar also complains about?

@ivarne
Copy link
Member Author

ivarne commented Oct 7, 2024

No, I just took the ones that seemed to be available with a code.

I’m not sure about the static if you don’t access class variables thing. It doesn’t always seem like an improvement to differentiate methods that write telemetry with a static modifier.

@ivarne
Copy link
Member Author

ivarne commented Oct 10, 2024

This is part of #730, and I seem to have not fixed all warnings here.

@ivarne ivarne closed this Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
ignore-for-release quality/debt
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ivarne @martinothamar